Messages in this thread | | | Date | Fri, 25 Apr 2008 14:27:17 +0800 | From | "Bryan Wu" <> | Subject | Re: [PATCH 2/3] [libata/BF54x]: Fix bug - Implement bfin ata interrupt handler to avoid "irq 68 nobody cared" |
| |
On Fri, Apr 25, 2008 at 1:17 PM, Jeff Garzik <jgarzik@pobox.com> wrote: > Bryan Wu wrote: > > > From: Sonic Zhang <sonic.zhang@analog.com> > > > > Return IRQ_HANDLED when bfin ata device is busy. > > > http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3513 > > > > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com> > > Signed-off-by: Bryan Wu <cooloney@kernel.org> > > --- > > drivers/ata/pata_bf54x.c | 125 > ++++++++++++++++++++++++++++++++++++++++++++-- > > 1 files changed, 121 insertions(+), 4 deletions(-) > > > > AFAICS the two new functions you add should be (a) marked 'static' and (b) > not marked 'inline'. > > We avoid inline these days, preferring to let the compiler make the best > choice for that platform/CPU. >
No problem, I will fix it.
-Bryan
| |