lkml.org 
[lkml]   [2008]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] x86: fix text_poke


On Fri, 25 Apr 2008, Ingo Molnar wrote:
>
> something like the patch below? (untested)

No. That whole code sequence is total and utter crap. It needs to be
rewritten.

It first does a BUG_ON() if it's not naturally aligned (because that
wouldn't be atomic), and then it has code for page crossing! What a TOTAL
PIECE OF SH*T!

Hint:
- if it's naturally aligned, it couldn't be page crossing ANYWAY
- and if it was a page-crosser, it sure as hell couldn't be atomic!

The code is just crap, crap, crap. It needs to be rewritten from scratch.
I'll have a patch soonish.

Linus


\
 
 \ /
  Last update: 2008-04-25 17:43    [from the cache]
©2003-2011 Jasper Spaans