lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is never below 0.
From
Date
On Wed, 2008-04-23 at 22:10 +0200, Roel Kluin wrote:
> priv->param_workaround_interval is unsigned,
> modparam_workaround_interval not.
> the former is never < 0.

> - priv->param_workaround_interval = modparam_workaround_interval;
>
> - if (priv->param_workaround_interval < 0)
> + if (modparam_workaround_interval < 0)
> priv->param_workaround_interval = 500;
> + else
> + priv->param_workaround_interval = modparam_workaround_interval;

Eh, why not make the modparam unsigned and default to 500?

johannes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-04-24 10:59    [W:0.221 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site