Messages in this thread | | | Subject | Re: [PATCH] PCI Express ASPM support should default to 'No' | From | Andi Kleen <> | Date | Thu, 24 Apr 2008 09:49:47 +0200 |
| |
Shaohua Li <shaohua.li@intel.com> writes:
> On Tue, 2008-04-22 at 17:12 -0700, Jesse Barnes wrote: >> On Tuesday, April 22, 2008 3:28 pm Jesper Juhl wrote: >> > Running 'make oldconfig' I just noticed that PCIEASPM defaults to >> > 'y' in Kconfig even though the feature is both experimental and the >> > help text recommends that if you are unsure you say 'n'. >> > It seems to me that this really should default to 'n', not 'y' at the >> > moment. >> > The following patch makes that change. Please consider applying. >> >> Seem reasonable, Shaohua? Please cc linux-pci on PCI patches >> though... > Ok, I'm fine with the patch. Though by default, the policy is to use > BIOS setting, that is if BIOS disables ASPM, we don't enable it too.
Once the feature is considered stable it would be nice to make it default y again. I think any power saving should be on by default (unless serious issues are known), not off.
-Andi
| |