lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] ia64: Remove printk noise on unimplemented SAL_PHYSICAL_ID_INFO
    Commit 113134fcbca83619be4c68d0ca66db6093777b5d changed the flow of
    control when calling PAL_LOGICAL_TO_PHYSICAL and SAL_PHYSICAL_ID_INFO.
    With the change, if a platform did not implement the latter, a useless
    printk would appear in the boot log:

    ia64_sal_pltid failed with -1

    So let's check the return code and only printk on a true error, and do
    not print anything in the unimplemented case. While we're in there,
    clean up some stylistic issues too.

    Signed-off-by: Alex Chiang <achiang@hp.com>
    ---
    arch/ia64/kernel/smpboot.c | 12 +++++++++---
    1 files changed, 9 insertions(+), 3 deletions(-)

    diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
    index 16483be..8d86e1f 100644
    --- a/arch/ia64/kernel/smpboot.c
    +++ b/arch/ia64/kernel/smpboot.c
    @@ -873,7 +873,8 @@ identify_siblings(struct cpuinfo_ia64 *c)
    u16 pltid;
    pal_logical_to_physical_t info;

    - if ((status = ia64_pal_logical_to_phys(-1, &info)) != PAL_STATUS_SUCCESS) {
    + status = ia64_pal_logical_to_phys(-1, &info);
    + if (status != PAL_STATUS_SUCCESS) {
    if (status != PAL_STATUS_UNIMPLEMENTED) {
    printk(KERN_ERR
    "ia64_pal_logical_to_phys failed with %ld\n",
    @@ -885,8 +886,13 @@ identify_siblings(struct cpuinfo_ia64 *c)
    info.overview_cpp = 1;
    info.overview_tpc = 1;
    }
    - if ((status = ia64_sal_physical_id_info(&pltid)) != PAL_STATUS_SUCCESS) {
    - printk(KERN_ERR "ia64_sal_pltid failed with %ld\n", status);
    +
    + status = ia64_sal_physical_id_info(&pltid);
    + if (status != PAL_STATUS_SUCCESS) {
    + if (status != PAL_STATUS_UNIMPLEMENTED)
    + printk(KERN_ERR
    + "ia64_sal_pltid failed with %ld\n",
    + status);
    return;
    }

    --
    1.5.3.1.g1e61


    \
     
     \ /
      Last update: 2008-04-24 20:55    [W:0.024 / U:124.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site