lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 10/15] m68k: Some network drivers do not check the platform
On Thu, Apr 24, 2008 at 08:29:50PM +0200, Geert Uytterhoeven wrote:
> +++ b/drivers/net/macmace.c
> @@ -781,6 +781,9 @@ static int __init mac_mace_init_module(v
> {
> int err;
>
> + if (!MACH_IS_MAC)
> + return -ENODEV;
> +
> if ((err = platform_driver_register(&mac_mace_driver))) {
> printk(KERN_ERR "Driver registration failed\n");
> return err;

This is rather odd. The whole point of the platform_driver
infrastructure is that the arch code only registers it if it's present
and then the driver can match for it. So the right fix here is to move
the platform_driver_register(&mac_mace_driver) into the mac arch setup
code. A quick grep shows this is a quite common pattern for m68k
drivers.



\
 
 \ /
  Last update: 2008-04-24 20:45    [W:0.110 / U:6.160 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site