lkml.org 
[lkml]   [2008]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] linux/atm_tcp.h: cleanup for userspace
From
From: Mike Frysinger <vapier@gentoo.org>
Date: Sat, 19 Apr 2008 23:22:34 -0400

> The atm_tcp.h uses types from linux/atm.h, but does not include it. It
> should also use the standard __u## types from linux/types.h rather than the
> uint##_t types since the former can be found with the kernel already.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

I don't think this is a sufficient patch to solve these problems.

> @@ -8,10 +8,8 @@
> #define LINUX_ATM_TCP_H
>
> #include <linux/atmapi.h>
> -
> -#ifdef __KERNEL__
> #include <linux/types.h>
> -#endif
> +#include <linux/atm.h>
> #include <linux/atmioc.h>
>
>

So you're adding linux/atm.h as an include for non-kernel, fine,
but:

> @@ -20,9 +18,9 @@
> */
>
> struct atmtcp_hdr {
> - uint16_t vpi;
> - uint16_t vci;
> - uint32_t length; /* ... of data part */
> + __u16 vpi;
> + __u16 vci;
> + __u32 length; /* ... of data part */
> };
>
> /*

Well, linux/atm.h, which we'll now get, has the same exact problem,
it uses "uint16_t" and related types.

Futehermore, nothing in the include chain will get linux/types.h
include, which we'll need. linux/atm.h protects the inclusion
of linux/types.h with __KERNEL__.


\
 
 \ /
  Last update: 2008-04-24 04:27    [W:0.139 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site