Messages in this thread Patch in this message | | | Date | Wed, 23 Apr 2008 18:51:17 +0200 | From | Roel Kluin <> | Subject | [PATCH] powerpc: mpic_pasemi_msi: failed allocation unnoticed |
| |
bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may return -ENOMEM, but hwirq of type irq_hw_number_t which is unsigned.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- The functions can be found respectively in: //---[ vi lib/bitmap.c +807 ]--- //---[ vi arch/powerpc/sysdev/mpic_msi.c +39 ]---
diff --git a/arch/powerpc/sysdev/mpic_pasemi_msi.c b/arch/powerpc/sysdev/mpic_pasemi_msi.c index 33cbfb2..a15ac5c 100644 --- a/arch/powerpc/sysdev/mpic_pasemi_msi.c +++ b/arch/powerpc/sysdev/mpic_pasemi_msi.c @@ -109,7 +109,7 @@ static int pasemi_msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) * sources can be changed independently. */ hwirq = mpic_msi_alloc_hwirqs(msi_mpic, ALLOC_CHUNK); - if (hwirq < 0) { + if (hwirq == -ENOMEM) { pr_debug("pasemi_msi: failed allocating hwirq\n"); return hwirq; }
| |