lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] xfs: do not pass unused params to xfs_flush_pages
    Date
    On Tuesday 22 April 2008 05:15, Eric Sandeen wrote:
    > Denys Vlasenko wrote:
    > > Hi David,
    > >
    > > xfs_flush_pages() does not use some of its parameters, namely:
    > > first, last and fiops.
    > >
    > > This patch removes these parameters from all callsites.
    > >
    > > Code size difference on 32-bit x86:
    > >
    > > text data bss dec hex filename
    > > 390739 2748 1708 395195 607bb linux-2.6-xfs1-TEST/fs/xfs/xfs.o
    > > 390567 2748 1708 395023 6070f linux-2.6-xfs2-TEST/fs/xfs/xfs.o
    > >
    > > Compile-tested only.
    >
    > FWIW this one actually does not seem to reduce stack usage anywhere.

    I hope this will not deteriorate into a contest whether
    every particular patch reduces stack usage or not, but:

    You do not see reduced stack usage in "make checkstack",
    because "make checkstack" shows only stack usage caused by
    local variables (it analyses sub %esp,NN instructions which
    make room for them). Parameters also take up stack, but
    they are pushed on stack with push instruction,
    and so are invisible in "make checkstack" output.
    --
    vda


    \
     
     \ /
      Last update: 2008-04-22 11:01    [W:0.020 / U:0.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site