lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: StackProtector Oopses - Re: 2.6.25-mm1

    * Arjan van de Ven <arjan@infradead.org> wrote:

    > > yeah. Arjan - any new patches to try that might fix the bootup test?
    >
    > I've looked at the disassembly and compared it to mine, and the gcc is
    > doing something... rather unexpected. The only thing I can think of is
    > the patch below, it should make it a ton more robust...

    > - memset(&foo, 0, 2*sizeof(foo)); /* deliberate buffer overflow */
    > + if (current->stack_canary == *(((unsigned long *)&foo)+1))
    > + *(((unsigned long *)&foo)+1) = 0;
    > + else
    > + printk(KERN_ERR "No -ftack-protector canary found\n");

    ok, i queued this up. (with the typo that Valdis noticed fixed)

    but ... this bug needs to be figured out, not worked around.

    Ingo


    \
     
     \ /
      Last update: 2008-04-22 10:37    [W:3.444 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site