lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: use smaller int param in call to xfs_flush_pages
On Tue, Apr 22, 2008 at 05:14:45AM +0200, Denys Vlasenko wrote:
> Hi David,
>
> xfs_flush_pages() flags parameter is declared as uint64_t, but
> code never pass values which do not fit into 32 bits.
> All callsites sans one pass zero, and the last one passes
> XFS_B_DELWRI, XFS_B_ASYNC or zero.
> These values are defined in enum xfs_buf_flags_t and they
> all fit in 32 bits.

Can you fold this into the previous patch that kills fiopt to
this function?

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group


\
 
 \ /
  Last update: 2008-04-23 00:11    [W:0.169 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site