lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs
Benjamin Herrenschmidt wrote:

> This fixes atyfb to not truncate 64 bits resources on 32 bits
> platforms. Unfortunately, there are still issues with addresses
> returned to userspace via struct fb_fix_screeninfo. This will
> have to be dealt with separately.

> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
[...]
> --- linux-work.orig/drivers/video/aty/atyfb_base.c 2008-04-22 11:21:46.000000000 +1000
> +++ linux-work/drivers/video/aty/atyfb_base.c 2008-04-22 11:23:58.000000000 +1000
> @@ -2842,7 +2842,7 @@ static int atyfb_setcolreg(u_int regno,
> #ifdef __sparc__
>
> static int __devinit atyfb_setup_sparc(struct pci_dev *pdev,
> - struct fb_info *info, unsigned long addr)
> + struct fb_info *info, resource_size_t addr)

Not sure what that change gives us -- this function mostly treats 'addr'
as unsigned long (casting it to char/void *), ot compares it to 'unsigned
long' 'base' variable -- which should be made 'resource_size_t' in its turn
being assigned resource's start value. So, this part of patch looks incomplete
(and yet I'm not sure if SPARC really needs all that)...

WBR, Sergei


\
 
 \ /
  Last update: 2008-04-22 17:47    [from the cache]
©2003-2011 Jasper Spaans