Messages in this thread | | | Date | Tue, 22 Apr 2008 08:45:16 +0200 | From | Nick Piggin <> | Subject | Re: [patch 01/17] hugetlb: modular state |
| |
On Mon, Apr 21, 2008 at 03:51:24PM -0500, Jon Tollefson wrote: > > On Fri, 2008-04-11 at 03:02 +1000, npiggin@suse.de wrote: > > <snip> > > > Index: linux-2.6/include/linux/hugetlb.h > > =================================================================== > > --- linux-2.6.orig/include/linux/hugetlb.h > > +++ linux-2.6/include/linux/hugetlb.h > > @@ -40,7 +40,7 @@ extern int sysctl_hugetlb_shm_group; > > > > /* arch callbacks */ > > > > -pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr); > > +pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr, int sz); > > <snip> > > The sz here needs to be a long to handle sizes such as 16G on powerpc. > > There are other places in hugetlb.c where the size also needs to be a > long, but this one affects the arch code too since it is public.
Thanks, I've fixed that and found (hopefully) the rest of the ones in the hugetlb.c code.
Thanks, Nick
| |