lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] klist: implement KLIST_INIT() and DEFINE_KLIST()
Peter Zijlstra wrote:
>> These locks don't nest so being in the same class should be okay and I
>> was following what (at least some of) other __SPIN_LOCK_UNLOCKED users
>> are doing. If putting these locks into separate classes is the RTTD, sure.
>
> Ah, they'll actually be in seprate classes all of the same name. So I
> think it is cleaner to cause them to have separate names too.
>
> see look_up_lock_class() in kernel/lockdep.c:
>
> /*
> * Static locks do not have their class-keys yet - for them the key
> * is the lock object itself:
> */
> if (unlikely(!lock->key))
> lock->key = (void *)lock;

Ah.. I'll put change it to name. Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-04-22 15:15    [W:0.037 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site