lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] xfs: do not pass size into kmem_free, it's unused
    Denys Vlasenko wrote:
    > Hi David,
    >
    >> Patches are welcome - I'd be over the moon if any of the known 4k
    >> stack advocates sent a stack reduction patch for XFS, but it seems
    >> that actually trying to fix the problems is much harder than
    >> resending a one line patch every few months....
    >
    > kmem_free() function takes (ptr, size) arguments but doesn't
    > actually use second one.
    >
    > This patch removes size argument from all callsites.

    I didn't expect it to but this does reduce a few things slightly.

    On x86_64:

    -xfs_attr_leaf_list_int 200
    +xfs_attr_leaf_list_int 184

    -xfs_dir2_sf_to_block 136
    +xfs_dir2_sf_to_block 120

    -xfs_ifree_cluster 136
    +xfs_ifree_cluster 120

    -xfs_inumbers 184
    +xfs_inumbers 168

    -xfs_mount_free 24

    Thanks,
    -Eric



    \
     
     \ /
      Last update: 2008-04-22 05:13    [W:0.036 / U:30.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site