lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Bug 10489] Kprobe smoke test lockdep warning
Thank you for reporting.

Actually, kprobes tries to fixup thread's flags in post_kprobe_handler
(which is called from kprobe_exceptions_notify) by
trace_hardirqs_fixup_flags(pt_regs->flags). However, even the irq flag
is set in pt_regs->flags, true hardirq is still off until returning
from do_debug. Thus, lockdep assumes that hardirq is off without annotation.

IMHO, one possible solution is that fixing hardirq flags right after
notify_die in do_debug instead of in post_kprobe_handler.

Thanks,


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2008-04-22 00:57    [from the cache]
©2003-2011 Jasper Spaans