lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [build bug] iwl-3945-led.c:(.text+0x119e36): undefined reference to `__led_classdev_unregister'
From
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 20 Apr 2008 09:34:41 +0200

> drivers/built-in.o: In function `iwl3945_led_unregister_led':
> iwl-3945-led.c:(.text+0x119e36): undefined reference to `__led_classdev_unregister'
> drivers/built-in.o: In function `iwl3945_led_register_led':
> iwl-3945-led.c:(.text+0x119ecd): undefined reference to `led_classdev_register'

Thanks for the report.

This is the classic "API_OPTION=m && API_USER=y" problem.

In this case the best fix is probably to use select in the
iwlwifi Kconfig files. The following patch should cure it.

iwlwifi: Use 'select' for MAC80211_LEDS and LEDS_CLASS instead of 'depends'

Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index f844b73..c4e631d 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -49,7 +49,9 @@ config IWL4965_HT

config IWL4965_LEDS
bool "Enable LEDS features in iwl4965 driver"
- depends on IWL4965 && MAC80211_LEDS && LEDS_CLASS
+ depends on IWL4965
+ select MAC80211_LEDS
+ select LEDS_CLASS
select IWLWIFI_LEDS
---help---
This option enables LEDS for the iwlwifi drivers
@@ -134,7 +136,9 @@ config IWL3945_SPECTRUM_MEASUREMENT

config IWL3945_LEDS
bool "Enable LEDS features in iwl3945 driver"
- depends on IWL3945 && MAC80211_LEDS && LEDS_CLASS
+ depends on IWL3945
+ select MAC80211_LEDS
+ select LEDS_CLASS
---help---
This option enables LEDS for the iwl3945 driver.


\
 
 \ /
  Last update: 2008-04-20 09:55    [W:0.049 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site