lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/15] drivers/char: minor irq handler cleanups
Alan Cox wrote:
> On Fri, Apr 18, 2008 at 07:22:51PM -0400, Jeff Garzik wrote:
>> +++ b/drivers/char/cyclades.c
>> if (unlikely(!ISZLOADED(*cinfo))) {
>> #ifdef CY_DEBUG_INTERRUPTS
>> - printk(KERN_DEBUG "cyz_interrupt: board not yet loaded "
>> - "(IRQ%d).\n", irq);
>> + printk(KERN_DEBUG "cyz_interrupt: board not yet loaded\n");
>
> If you are debugging IRQ funnies you really really want to know which
> IRQ or which port.
>
> Ack the rest on the base the __foo_interrupt uglies will go away with the
> final change over. A follow up patch to tweak cyclades would be useful and also
> to know from Andrew if these are going in so they don't clash with the coding
> style cleanups also queued.

In the stuff I pushed just now, I took the attitude "if there was
remotely a peep from anyone, do not send it"

So the stuff ya'll mentioned shouldn't be in the push at all.

In particular, I wanted to note the __foo_interrupt stuff will not go
away when I remove the 'irq' arg from all handlers... we still need to
indicate two separate callsites (local poll or system irq) to achieve
the same behavior as exists today.

Jeff




\
 
 \ /
  Last update: 2008-04-21 03:41    [W:0.068 / U:3.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site