lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/8] omfs: add inode routines
On Sun, Apr 20, 2008 at 11:57:22AM +0200, Marcin Slusarz wrote:
> > > +static void set_block_shift(struct omfs_sb_info *sbi)
> > > +{
> > > + unsigned int scale = sbi->s_blocksize / sbi->s_sys_blocksize;
[...]
> > isn't it get_bitmask_order(scale - 1)?
>
> I mean get_bitmask_order(scale >> 1) ;)

Thank you for your comments. Hmm, yeah I think so. It could also
lose the divide:

scale = get_bitmask_order(sbi->s_blocksize) -
get_bitmask_order(sbi->s_sys_blocksize);

(or ffs/fls for that matter.)

--
Bob Copeland %% www.bobcopeland.com



\
 
 \ /
  Last update: 2008-04-21 02:45    [W:0.036 / U:17.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site