lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] soft lockup rose_node_list_lock
From
From: Bernard Pidoux <pidoux@ccr.jussieu.fr>
Date: Sun, 20 Apr 2008 19:09:23 +0200

> Since rose_route_frame() does not use rose_node_list we can safely
> remove rose_node_list_lock spin lock here and let it be free for
> rose_get_neigh().
>
> Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>

Indeed, I went over this code several times and I can't
see any reason for rose_route_frame() to take the node
list lock.

Patch applied, thanks Bernard. But one thing...

> diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
> index fb9359f..5053a53 100644
> --- a/net/rose/rose_route.c
> +++ b/net/rose/rose_route.c
> @@ -857,7 +857,6 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)
> src_addr = (rose_address *)(skb->data + 9);
> dest_addr = (rose_address *)(skb->data + 4);
>
> - spin_lock_bh(&rose_node_list_lock);
> spin_lock_bh(&rose_neigh_list_lock);
> spin_lock_bh(&rose_route_list_lock);
>

Could you please fix your email client so it doesn't corrupt
patches like this? I've had to apply all of your patches by
hand because the tabs have been converted into spaces. Use
MIME attachments if you have to.

Thanks again.


\
 
 \ /
  Last update: 2008-04-21 01:03    [W:0.050 / U:3.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site