lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PATCH] SCSI updates for 2.6.25
On Sun, Apr 20, 2008 at 04:09:27PM +0200, Stefan Richter wrote:
> Matthew Wilcox wrote:
> >--- a/Documentation/kbuild/kconfig-language.txt
> >+++ b/Documentation/kbuild/kconfig-language.txt
> > Note:
> >- select is evil.... select will by brute force set a symbol
> >- equal to 'y' without visiting the dependencies. So abusing
> >- select you are able to select a symbol FOO even if FOO depends
> >+ select should be used with care. It can set a symbol
> >+ without visiting the dependencies. By abusing select you are
> >+ able to select a symbol FOO even if FOO depends
> > on BAR that is not set. In general use select only for
> > non-visible symbols (no prompts anywhere) and for symbols with
> > no dependencies. That will limit the usefulness but on the
>
> "It can set a symbol without visiting the dependencies." = imprecise
>
> "select will by brute force set a symbol [...] without visiting the
> dependencies." = clear. So why not leave this portion of the text as it is.

"brute force" is pejorative, not clear. I'm not really interested in
bikeshedding this issue.

> Maybe change
> "equal to 'y'"
> to
> "equal to 'y' or 'm'"
> or to
> ""
> to make it entirely correct.
> --
> Stefan Richter
> -=====-==--- -=-- =-=--
> http://arcgraph.de/sr/

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."


\
 
 \ /
  Last update: 2008-04-20 21:59    [W:0.044 / U:2.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site