lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree
On Sun, Apr 20, 2008 at 08:21:49PM +0400, Denis V. Lunev wrote:
>
> On Sun, 2008-04-20 at 18:37 +0400, Alexey Dobriyan wrote:
> > On Tue, Apr 15, 2008 at 04:55:57PM -0700, akpm@linux-foundation.org wrote:
> > > --- a/fs/nfsd/nfsctl.c~nfsd-use-proc_create-to-setup-de-proc_fops
> > > +++ a/fs/nfsd/nfsctl.c
> >
> > > @@ -736,10 +737,9 @@ static int create_proc_exports_entry(voi
> > > entry = proc_mkdir("fs/nfs", NULL);
> > > if (!entry)
> > > return -ENOMEM;
> > > - entry = create_proc_entry("fs/nfs/exports", 0, NULL);
> > > + entry = proc_create("exports", 0, entry, &exports_operations);
> > ^^^^^^^^^
> ^^^^^^^
> > > if (!entry)
> > > return -ENOMEM;
> > > - entry->proc_fops = &exports_operations;
> >
> > "fs/nfs/exports" is used in full in this file. And line will fit into
> > 80 columns.
> >
> This is a pde for fs/nfs.

Yes, why change it?

> So, this will be slightly less operations in my case.

It's done once per module loading, so nobody cares.



\
 
 \ /
  Last update: 2008-04-20 19:55    [W:0.033 / U:25.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site