lkml.org 
[lkml]   [2008]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ofa-general] Re: [GIT PULL] please pull infiniband.git
On Sat, 19 Apr 2008, Roland Dreier wrote:
| Not sure I really follow this response... ipath_driver.c has
|
| case PCI_DEVICE_ID_INFINIPATH_7220:
| #ifndef CONFIG_PCI_MSI
| ipath_dbg("CONFIG_PCI_MSI is not enabled, "
| "using IntX for unit %u\n", dd->ipath_unit);
| #endif
| ipath_init_iba7220_funcs(dd);
| break;
|
| so clearly ipath_init_iba7220_funcs() was intended to be built and used
| even if CONFIG_PCI_MSI was not defined. From the code it looks like all
| should work fine if PCI_MSI is not set, so I don't know what you mean
| about conditional checks.

Actually, it wasn't. It was a late cleanup for another problem, and
we didn't worry about the other issue, and should have.

| (BTW since I'm looking at this code, "IntX" should probably be
| capitalized as "INTx" to match what the PCI specs say)

True.

Dave Olson
dave.olson@qlogic.com


\
 
 \ /
  Last update: 2008-04-20 16:51    [W:0.033 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site