lkml.org 
[lkml]   [2008]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] usb ehci_iaa_watchdog fix
Date
On Wednesday 02 April 2008, Alan Stern wrote:
> > -     if (ehci->reclaim
> > -                     && !timer_pending(&ehci->iaa_watchdog)
> > -                     && HC_IS_RUNNING(ehci_to_hcd(ehci)->state)) {
> > +     if (ehci->reclaim && !timer_pending(&ehci->iaa_watchdog)) {
> >               u32 cmd, status;
> >  
> >               /* If we get here, IAA is *REALLY* late.  It's barely
>
> Okay, I'm puzzled.  How could this make any difference?

It's more like: what else in that patch could have had
any such effect? That HC_IS_RUNNING test was the only
candidate.

Those hcd->state tests have been getting more and more
dodgey as time goes by. At this point I hardly trust
any of them. There *IS* no clear state machine which
governs the usbcore/HCD interaction.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-04-02 22:47    [from the cache]
©2003-2011 Jasper Spaans