Messages in this thread | | | Date | Wed, 2 Apr 2008 21:07:13 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH 1/3] hugetlbfs: architecture header cleanup |
| |
On Wed, Apr 02, 2008 at 10:42:56AM -0700, Dave Hansen wrote: > > On Wed, 2008-04-02 at 16:26 +0200, Gerald Schaefer wrote: > > > > include/asm-ia64/hugetlb.h | 21 +++++++++++++++++++ > > include/asm-ia64/page.h | 6 ----- > > include/asm-powerpc/hugetlb.h | 35 +++++++++++++++++++++++++++++++ > > include/asm-powerpc/page_64.h | 7 ------ > > include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++ > > include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++ > > include/asm-sparc64/page.h | 2 - > > include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++ > > include/linux/hugetlb.h | 46 ------------------------------------------ > > The way I read this, you took some arch-independent bits, like > prepare_hugepage_range(), and copied them to several architectures. How > is this a cleanup? Can they really not share common code?
This question has been raised before. See: http://lkml.org/lkml/2008/3/28/267 .
| |