lkml.org 
[lkml]   [2008]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kmemcheck caught read from freed memory (cfq_free_io_context)
On Wed, Apr 02 2008, Jens Axboe wrote:
> On Wed, Apr 02 2008, Fabio Checconi wrote:
> > > From: Jens Axboe <jens.axboe@oracle.com>
> > > Date: Wed, Apr 02, 2008 02:36:39PM +0200
> > >
> > > > Looks good and tests fine as well. I've applied it, on top of the
> > > > hlist_for_each_entry_safe_rcu() fix.
> > > >
> > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=436151ad32b4a59e0d36165a7d6312545f126661
> > > >
> >
> > ok, thanks. anyway I don't think the hlist_for_each_entry_safe_rcu()
> > is needed at this point, since the pos->next pointer is still valid
> > (at least) until the next rcu_read_unlock(). am I wrong?
>
> it isn't, but it's still clearer. so either that or a nice comment, I
> just stuck with what I had already committed.

Christ, mutt is still dropping you. Sorry about that.

--
Jens Axboe



\
 
 \ /
  Last update: 2008-04-02 15:01    [W:0.136 / U:0.392 seconds]
©2003-2011 Jasper Spaans