Messages in this thread | | | Date | Wed, 2 Apr 2008 14:58:19 +0200 | From | Jens Axboe <> | Subject | Re: kmemcheck caught read from freed memory (cfq_free_io_context) |
| |
On Wed, Apr 02 2008, Fabio Checconi wrote: > > From: Jens Axboe <jens.axboe@oracle.com> > > Date: Wed, Apr 02, 2008 02:36:39PM +0200 > > > > > Looks good and tests fine as well. I've applied it, on top of the > > > hlist_for_each_entry_safe_rcu() fix. > > > > > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=436151ad32b4a59e0d36165a7d6312545f126661 > > > > > ok, thanks. anyway I don't think the hlist_for_each_entry_safe_rcu() > is needed at this point, since the pos->next pointer is still valid > (at least) until the next rcu_read_unlock(). am I wrong?
it isn't, but it's still clearer. so either that or a nice comment, I just stuck with what I had already committed.
-- Jens Axboe
| |