Messages in this thread | | | Date | Wed, 02 Apr 2008 13:01:32 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH] Drop an empty byteorder/generic.h from being exported to userspace. |
| |
On 04/02/2008 01:00 PM, Robert P. J. Day wrote: > On Wed, 2 Apr 2008, Jiri Slaby wrote: > >> On 04/02/2008 03:38 AM, Robert P. J. Day wrote: >>> Since the entire meaningful contents of generic.h is wrapped by the >>> __KERNEL__ test, drop it from being passed to userspace, and remove >>> the now superfluous __KERNEL__ test. >>> >>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> >>> >>> --- >>> >>> is there some value in allowing an effectively empty header file to >>> be exported to userspace? >> Not breaking the userspace? The file is included in non-__KERNEL__ >> sections from byteorder/*_endian.h. > > ok ... and the value of including a completely empty header file is > ... ?
No value, you should just move those includes into the __KERNEL__ part.
| |