Messages in this thread | | | Date | Sat, 19 Apr 2008 15:22:37 +1000 | From | Paul Mackerras <> | Subject | Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers |
| |
David Miller writes: > From: Paul Mackerras <paulus@samba.org> > Date: Sat, 19 Apr 2008 14:04:32 +1000 > > > Jochen Friedrich writes: > > > > > Fix build breakage introduced in commit > > > "[POWERPC] i2c: OF helpers for the i2c API". > > > If i2c-core is compiled as module, the helper needs to be > > > compiled as module, as well. Rename i2c.c to of_i2c.c to > > > avoid name space conflict. > > > > Actually, since only powerpc has irq_of_parse_and_map, I'm now > > inclined to think that drivers/of/i2c.c should live under arch/powerpc > > for now, or at the least its option should depend on PPC_OF. > > I specifically asked for this to not be PPC only so that I > can make use of this infrastructure on sparc64 for I2C devices.
OK.
> It's OK if this breaks the sparc64 allmodconfig build, I'll take > care of this once it's merged in.
It breaks the sparc32 allmodconfig build, which seems to be a concern. How do you suggest we fix that?
> Please merge the PPC tree to Linus soon, so that I can merge > in my sparc64 NUMA bits which depend upon the LMB changesets > in the PPC tree.
Sure, it's just this sparc32 breakage which is holding me up.
Paul.
| |