lkml.org 
[lkml]   [2008]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][RFC] Add default CPU topology information
    Andrew Morton wrote:
    > On Mon, 31 Mar 2008 12:44:13 +0100 Ben Hutchings <bhutchings@solarflare.com> wrote:
    >
    > > Not all architectures and configurations define CPU topology information.
    > > This can result in an empty topology directory in sysfs, and requires
    > > in-kernel users to protect all uses with #ifdef - see
    > > <http://marc.info/?l=linux-netdev&m=120639033904472&w=2>.
    > >
    > > The documentation of CPU topology specifies what the defaults should be
    > > if only partial information is available from the hardware. So we can
    > > provide these defaults as a fallback.
    > >
    > > This patch:
    > >
    > > - Adds default definitions of the 4 topology macros to
    > > include/asm-generic/topology.h.
    > > - Changes include/asm-*/topology.h to include <asm-generic/topology.h>
    > > unconditionally.
    > > - Changes drivers/base/topology.c to use the topology macros unconditionally
    > > and to cope with definitions that aren't lvalues.
    > > - Updates documentation accordingly.
    >
    > I get a huuuuuuuge crash early in boot on the t61p dual x86_64 laptop.
    > Before netconsole has started and it has no serial port, so all I have is a
    > partially-scrolled-off jpg, sorry.
    >
    > I'll drop the patch.
    <snip>

    Damn, x86 is also using functions instead of macros. Sorry about that; I'll
    have another try.

    Ben.

    --
    Ben Hutchings, Senior Software Engineer, Solarflare Communications
    Not speaking for my employer; that's the marketing department's job.


    \
     
     \ /
      Last update: 2008-04-18 14:27    [W:0.019 / U:91.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site