Messages in this thread | | | Date | Fri, 18 Apr 2008 13:10:17 +0100 | From | Ben Hutchings <> | Subject | Re: [PATCH][RFC] Add default CPU topology information |
| |
Andrew Morton wrote: > On Mon, 31 Mar 2008 12:44:13 +0100 Ben Hutchings <bhutchings@solarflare.com> wrote: > > > Not all architectures and configurations define CPU topology information. > > This can result in an empty topology directory in sysfs, and requires > > in-kernel users to protect all uses with #ifdef - see > > <http://marc.info/?l=linux-netdev&m=120639033904472&w=2>. > > > > The documentation of CPU topology specifies what the defaults should be > > if only partial information is available from the hardware. So we can > > provide these defaults as a fallback. > > powerpc allmodconfig: > > arch/powerpc/kernel/pci_64.c:655: error: expected identifier or '(' before 'void' > arch/powerpc/kernel/pci_64.c:655: error: expected ')' before '(' token <snip > gets it working, by tricking the preprocessor into expanding pcibus_to_node > to itself, but it isn't exactly pleasing.
No, it isn't! But cputopology.txt does say these should be macros, not functions.
Ben.
-- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job.
| |