Messages in this thread | | | Subject | Re: [RFC PATCH 1/2] Marker probes in futex.c | From | (Frank Ch. Eigler) | Date | Thu, 17 Apr 2008 18:02:21 -0400 |
| |
Peter Zijlstra <a.p.zijlstra@chello.nl> writes:
> [...] >> If we were to log just the futex_ops, just as you had suggested, >> "Just log: >> >> futex: <uaddr> wait >> futex: <uaddr> wakeup" >> [...] >> If you can specifically point me to information you think would be >> absolutely unnecessary, I can get them out of the trace_mark(). > > I'm thinking everything is superflous; you're basically logging what > strace already gives you
But we don't want to run strace just for this stuff. As you probably know, strace involves invasive user-space context-switching between the target and the tracer.
> except worse by encoding local variable names and exposing kernel > pointers.
The pointers are probably excessive, the and the names don't really matter. What does matter is providing enough information for a problem diagnosis tool & person to reconstruct what the kernel must have been thinking when it did something noteworthy.
- FChE
| |