Messages in this thread Patch in this message | | | Date | Thu, 17 Apr 2008 20:38:57 +0200 | From | Roel Kluin <> | Subject | [PATCH] OSS: dmabuf: fix negative DMAbuf_get_buffer_pointer() check |
| |
Too late for OSS? --- Since unsigned active_offs < 0 is even true when DMAbuf_get_buffer_pointer() returns negative
Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/sound/oss/dmabuf.c b/sound/oss/dmabuf.c index eaf6997..1e90d76 100644 --- a/sound/oss/dmabuf.c +++ b/sound/oss/dmabuf.c @@ -795,9 +795,9 @@ static int find_output_space(int dev, char **buf, int *size) #ifdef BE_CONSERVATIVE active_offs = dmap->byte_counter + dmap->qhead * dmap->fragment_size; #else - active_offs = DMAbuf_get_buffer_pointer(dev, dmap, DMODE_OUTPUT); + active_offs = max(DMAbuf_get_buffer_pointer(dev, dmap, DMODE_OUTPUT), 0); /* Check for pointer wrapping situation */ - if (active_offs < 0 || active_offs >= dmap->bytes_in_use) + if (active_offs >= dmap->bytes_in_use) active_offs = 0; active_offs += dmap->byte_counter; #endif
| |