Messages in this thread | | | Date | Thu, 17 Apr 2008 18:09:51 +0200 | From | Takashi Iwai <> | Subject | Re: [alsa-devel] [PATCH] SOC: fix tests in cs4270_hw_params() |
| |
At Thu, 17 Apr 2008 17:45:39 +0200, Roel Kluin wrote: > > cs4270_hw_params does several times: > > ret = snd_soc_write() > if (ret < 0) > ... > > This only works when ret is signed. > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Applied to ALSA tree. Thanks.
Takashi
> --- > diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c > index bf2ab72..e73fcfd 100644 > --- a/sound/soc/codecs/cs4270.c > +++ b/sound/soc/codecs/cs4270.c > @@ -372,7 +372,7 @@ static int cs4270_hw_params(struct snd_pcm_substream *substream, > struct snd_soc_device *socdev = rtd->socdev; > struct snd_soc_codec *codec = socdev->codec; > struct cs4270_private *cs4270 = codec->private_data; > - unsigned int ret = 0; > + int ret; > unsigned int i; > unsigned int rate; > unsigned int ratio; > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
| |