Messages in this thread | | | Date | Thu, 17 Apr 2008 15:10:38 +0200 | From | Patrick McHardy <> | Subject | Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init() |
| |
jamal wrote: > On Thu, 2008-17-04 at 06:55 +0200, Patrick McHardy wrote: > >> The change is also unnecessary because the attribute was >> already validated and the length can not be less than zero. > > Since act_simple is an academic example: > I think that a better solution is to add TCA_DEF_DATA (which is a > string) to the nla_policy. nla_policy is defined but at the moment it is > not used in the call to nla_parse_nested() - might as well use it.
Basic validity checks are always performed. But I agree, better to provide a good example.
| |