[lkml]   [2008]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
    jamal wrote:
    > On Thu, 2008-17-04 at 06:55 +0200, Patrick McHardy wrote:
    >> The change is also unnecessary because the attribute was
    >> already validated and the length can not be less than zero.
    > Since act_simple is an academic example:
    > I think that a better solution is to add TCA_DEF_DATA (which is a
    > string) to the nla_policy. nla_policy is defined but at the moment it is
    > not used in the call to nla_parse_nested() - might as well use it.

    Basic validity checks are always performed. But I agree, better
    to provide a good example.

     \ /
      Last update: 2008-04-17 15:13    [W:0.022 / U:146.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site