lkml.org 
[lkml]   [2008]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
From
From: Roel Kluin <12o3l@tiscali.nl>
Date: Thu, 17 Apr 2008 05:33:21 +0200

> 'datalen' is unsigned, use 'ret' instead to catch a negative return value.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
> index fbde461..b78d015 100644
> --- a/net/sched/act_simple.c
> +++ b/net/sched/act_simple.c
> @@ -114,9 +114,10 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
> if (defdata == NULL)
> return -EINVAL;
>
> - datalen = nla_len(tb[TCA_DEF_DATA]);
> - if (datalen <= 0)
> + ret = nla_len(tb[TCA_DEF_DATA]);
> + if (ret <= 0)
> return -EINVAL;
> + datalen = ret;
>
> pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);
> if (!pc) {

This clobbers 'ret' which is compared to ACT_P_CREATED
later in the function. If the !pc branch below this code
is not taken, ret must be left at it's initial value of
zero. Now, it will take on some non-zero positive value
which is not correct.



\
 
 \ /
  Last update: 2008-04-17 06:39    [from the cache]
©2003-2011 Jasper Spaans