lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v2)

* Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:

> Implements an alternative iret with popf and return so trap and
> exception handlers can return to the NMI handler without issuing iret.
> iret would cause NMIs to be reenabled prematurely. x86_32 uses popf
> and far return. x86_64 has to copy the return instruction pointer to
> the top of the previous stack, issue a popf, loads the previous esp
> and issue a near return (ret).

thanks Mathieu, i've picked this up into x86.git for more testing.

note that this also fixes an oprofile regression: when oprofile is used
to generate stack-backtraces, we can fault on address resolution from
NMI context and currently we do an IRET - with your fixes it should work
fine. Obscure case but still worth fixing.

Ingo


\
 
 \ /
  Last update: 2008-04-16 15:09    [W:1.886 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site