lkml.org 
[lkml]   [2008]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: fix routine name in ptmx_open()
On Mon, 14 Apr 2008 17:55:49 -0700
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> At ptmx_open(), the 2nd parameter for check_tty_count() should
> be "ptmx_open".
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> ---
> drivers/char/tty_io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index 613ec81..546217d 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
> if (devpts_pty_new(tty->link))
> goto out1;
>
> - check_tty_count(tty, "tty_open");
> + check_tty_count(tty, "ptmx_open");
> retval = ptm_driver->open(tty, filp);
> if (!retval) {
> tty_audit_opening();

Of course, using __func__ prevents this sort of bitrot.

Or even #define check_tty_count(tty) __check_tty_count(tty, __func__)




\
 
 \ /
  Last update: 2008-04-16 00:05    [from the cache]
©2003-2011 Jasper Spaans