lkml.org 
[lkml]   [2008]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers
On Mon, 14 Apr 2008 03:53:02 -0400 Andres Salomon <dilinger@queued.net> wrote:

>
> Since there's no way to autodetect panel modes, we're forced to hardcode
> them in the driver and add a big fat #ifdef. The OLPC DCON needs a
> specific mode line (at 1200x900). This adds it to both gxfb and lxfb.
>
> ...
>
> +static const struct fb_videomode gx_dcon_modedb[] __initdata = {
> +const struct fb_videomode olpc_dcon_modedb[] __initdata = {

include/linux/init.h:38 points out that `const' and `__initdata' should
not be mixed.

I forget which architecture/compiler versions explode when we do this. But
it's not x86, iirc.

Still, it's poor form and, err, I don't immediately recall which tag we
_should_ use, and the comments in there are unhelpful. It might be
__initconst, but that has exactly zero users. Help.



\
 
 \ /
  Last update: 2008-04-15 03:25    [W:0.067 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site