Messages in this thread | | | Date | Mon, 14 Apr 2008 09:18:56 -0600 | From | Jordan Crouse <> | Subject | Re: OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers |
| |
On 14/04/08 10:33 +0200, Arnd Bergmann wrote: > On Monday 14 April 2008, Andres Salomon wrote: > > Since there's no way to autodetect panel modes, we're forced to hardcode > > them in the driver and add a big fat #ifdef. The OLPC DCON needs a > > specific mode line (at 1200x900). This adds it to both gxfb and lxfb. > > > > Signed-off-by: Andres Salomon <dilinger@debian.org> > > Since the XO is based on Open Firmware, shouldn't the panel size really be > a property in the device tree that can be read by this driver?
Andre's description was slightly misleading. We could probably detect the panel mode, but there isn't any reason to since the panel timings are well known and won't change. While OFW detection would be good computer science fu, it would be a wasted effort since its so easy to hard code them into the table.
Jordan
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |