lkml.org 
[lkml]   [2008]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] e1000=y && e1000e=m regression fix
On Fri, 11 Apr 2008, Linus Torvalds wrote:

>
>
> On Fri, 11 Apr 2008, Daniel Barkalow wrote:
> >
> > Wouldn't it make more sense to turn E1000 into a option that does nothing
> > except select both E1000E and E1000_PCI, and have those two be the options
> > that build drivers?
>
> Yes, that sounds fine too. Although you need to add a
>
> depends on PCI
>
> to the E1000 thing (because the "select" would not honor the dependencies
> that E1000E and E1000_PCI have).

Oh, right.

> However:
>
> > Then, after a while, we drop the E1000 option entirely
>
> I agree we could, but as I tried to explain, I fundamentally don't think
> we _should_.
>
> Why should people _ever_ be asked about whether they want "E1000 PCI
> support" vs "E1000 PCI-E" support, when it's almost impossible to tell
> which kind of card you have?
>
> In other words, I suspect that anybody who selects E1000 support would
> actually want the "support both" case, and simply not care. Unless they
> were _really_ deeply aware of their hardware.

Eh, they'll both default to Y on PCs individually, so it's only people who
are turning unused stuff off who will even look, and they'll probably ask
/sys/class/net/eth0/device/driver or lsmod.

-Daniel
*This .sig left intentionally blank*


\
 
 \ /
  Last update: 2008-04-12 01:17    [W:0.141 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site