lkml.org 
[lkml]   [2008]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4 v2] [RFC] UIO: generic platform driver
On Fri, Apr 11, 2008 at 01:03:58PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> Hans J. Koch wrote:
> > On Fri, Apr 11, 2008 at 11:21:58AM +0200, Uwe Kleine-König wrote:
> > >
> > > Below is a new version that uses linux/stringify and zeros size for
> > > unused mappings (line 102ff).
> >
> > Thanks, but it doesn't compile, neither with -rc8 nor with Linus' git.
> >
> > One problem can easily be fixed, the macro is called __stringify, not
> > stringify.
> I just notice that, too. My mail address that and your's just crossed
> each other.
>
> > But what about this:
> >
> > ERROR: "clk_get" [drivers/uio/uio_pdrv.ko] undefined!
> > ERROR: "clk_enable" [drivers/uio/uio_pdrv.ko] undefined!
> > ERROR: "clk_disable" [drivers/uio/uio_pdrv.ko] undefined!
> > ERROR: "clk_put" [drivers/uio/uio_pdrv.ko] undefined!
> >
> > Do you have any extra patches applied?
> Yes I have, but nothing special. This is part of a generic API defined
> in include/linux/clk.h. One of it's use it to abstract away some
> platform dependencies. There are several architectures that define
> it[1].

I know. Unfortunately, I tested on x86_64, and it doesn't compile.
If it's depending on something, then this dependency should be added in
Kconfig. If it can be selected in the configuration, I expect it to
compile (and work).

Thanks,
Hans


> I used it to allow enabling the device only when the device is
> opened. Typical things in the enable routine are enabling a clock or
> reserve and configure gpios etc.
>
> A minimal dummy implementation that should work here is:
>
> #define clk_get(dev, id) NULL
> #define clk_put(clk) ((void)0)
> #define clk_enable(clk) (1)
> #define clk_disable(clk) ((void)0)
>
> Best regards
> Uwe
>
> [1] Try:
>
> git ls-files -z | xargs -0 perl -n -e 'print "$ARGV\n" if /EXPORT_SYMBOL(?:_GPL)?\s*\(\s*clk_get\s*\)/;'
>
> --
> Uwe Kleine-König, Software Engineer
> Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
> Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-04-11 13:19    [W:0.188 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site