Messages in this thread | | | Date | Thu, 10 Apr 2008 16:52:49 -0700 | From | "SL Baur" <> | Subject | Re: [patch] checkpatch: relax spacing and line length |
| |
On 4/9/08, Benny Halevy <bhalevy@panasas.com> wrote:
> In http://lkml.org/lkml/2008/2/26/533, > SL Baur <steve <at> xemacs.org> said: > > The proposed two space change is ugly. Can someone NAK it? > > I'm not sure what "two space change" proposal this Steve referred to > and his rejection is based on not-to-sound aesthetic grounds. > > The motivation behind our proposal is more than just aesthetic. > I believe that using tabs for indent and then spaces for alignment > is functionally better, works for everybody, and will eventually result > in a more readable code over time, hopefully leading to fewer bugs.
Tabs + a variable number spaces to match up logically with the previous line is O.K. Tabs + exactly two spaces is what I objected to. I only posted due to being the originator of the Linux Kernel Emacs cc-mode style and cc-mode works like the former.
For whatever it's worth, my sentiments are on the David Miller side, having been the lucky recipient of format changes only patch bombs before. I suppose you should be glad you don't have someone running a spell checker on the entire source code.
-sb
| |