lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] checkpatch: relax spacing and line length
On 4/9/08, Benny Halevy <bhalevy@panasas.com> wrote:

> In http://lkml.org/lkml/2008/2/26/533,
> SL Baur <steve <at> xemacs.org> said:
> > The proposed two space change is ugly. Can someone NAK it?
>
> I'm not sure what "two space change" proposal this Steve referred to
> and his rejection is based on not-to-sound aesthetic grounds.
>
> The motivation behind our proposal is more than just aesthetic.
> I believe that using tabs for indent and then spaces for alignment
> is functionally better, works for everybody, and will eventually result
> in a more readable code over time, hopefully leading to fewer bugs.

Tabs + a variable number spaces to match up logically with the
previous line is O.K. Tabs + exactly two spaces is what I objected
to. I only posted due to being the originator of the Linux Kernel Emacs
cc-mode style and cc-mode works like the former.

For whatever it's worth, my sentiments are on the David Miller side,
having been the lucky recipient of format changes only patch bombs
before. I suppose you should be glad you don't have someone running
a spell checker on the entire source code.

-sb


\
 
 \ /
  Last update: 2008-04-11 01:55    [W:1.656 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site