lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] lzo: fix possible typo in decompresor
    From
    Date
    On Thu, 2008-04-10 at 13:49 -0700, Linus Torvalds wrote:
    >
    > On Thu, 10 Apr 2008, Harvey Harrison wrote:
    > >
    > > Shift of a le value seems strange, probably meant to shift the cpu-order
    > > variable as in the prvious section of the switch statement.
    >
    > Hmm. This patch looks ObviouslyCorrect(tm), but it worries me that
    > apparently the old broken code has been around since last July, and afaik
    > it can never have worked on big-endian machines.
    >
    > So did nobody ever use it, or why hasn't this ever triggered? How did you
    > find this? A sparse warning?
    >
    > Linus

    When converting in tree users to my proposed unaligned byteswapping api.
    See the 8 patch series posted today to linux-arch.

    Harvey



    \
     
     \ /
      Last update: 2008-04-10 22:55    [W:0.050 / U:0.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site