lkml.org 
[lkml]   [2008]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)
Date
On Tuesday, 1 of April 2008, Benjamin Herrenschmidt wrote:
>
> On Tue, 2008-04-01 at 19:15 +1100, Nigel Cunningham wrote:
> > > + * However, drivers may NOT assume anything about the availability of the
> > > + * user space at that time and it is not correct to request firmware from
> > > + * within @prepare() (it's too late to do that).
> >
> > That doesn't sound good. It would be good to be able to get drivers to
> > request firmware early in the process.
>
> Agreed. Prepare() should still allow request_firmware and full userspace
> communication / helper usage.

This documents the current state which is that we have the freezer and we have
drivers that rely on it.

I can remove the comment, but then someone will invent ->prepare() relying
on the availability of the user space at this point and that won't work.

Thanks,
Rafael


\
 
 \ /
  Last update: 2008-04-01 22:19    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog