lkml.org 
[lkml]   [2008]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86: Debug Store - call kfree if only we really need it
    We should call for kfree if only we really need it.
    Though it's safe to call kfree with NULL pointer passed
    in this code we've already tested the pointer and can
    eliminate the call

    Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
    ---

    ds.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    Index: linux-2.6.git/arch/x86/kernel/ds.c
    ===================================================================
    --- linux-2.6.git.orig/arch/x86/kernel/ds.c 2008-03-30 15:05:50.000000000 +0400
    +++ linux-2.6.git/arch/x86/kernel/ds.c 2008-04-01 19:20:20.000000000 +0400
    @@ -220,11 +220,11 @@ int ds_allocate(void **dsp, size_t bts_s

    int ds_free(void **dsp)
    {
    - if (*dsp)
    + if (*dsp) {
    kfree((void *)get_bts_buffer_base(*dsp));
    - kfree(*dsp);
    - *dsp = NULL;
    -
    + kfree(*dsp);
    + *dsp = NULL;
    + }
    return 0;
    }


    \
     
     \ /
      Last update: 2008-04-01 17:45    [W:0.021 / U:29.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site