| Date | Tue, 1 Apr 2008 15:08:36 +0300 | From | "Pekka Enberg" <> | Subject | Re: [RFC PATCH 20/26] UBIFS: add VFS operations |
| |
Hi Artem,
On Thu, Mar 27, 2008 at 5:55 PM, Artem Bityutskiy <Artem.Bityutskiy@nokia.com> wrote: > +static int ubifs_set_page_dirty(struct page *page) > +{ > + /* > + * An attempt to dirty a page without budgeting for it - should not > + * happen. > + */ > + ubifs_assert(0); > + return __set_page_dirty_nobuffers(page); > +} > + > +static int ubifs_releasepage(struct page *page, gfp_t unused_gfp_flags) > +{ > + /* > + * An attempt to release a dirty page without budgeting for it - should > + * not happen. > + */ > + ubifs_assert(PageLocked(page)); > + if (PageWriteback(page)) > + return 0; > + ubifs_assert(PagePrivate(page)); > + ubifs_assert(0); > + ClearPagePrivate(page); > + ClearPageChecked(page); > + return 1; > +}
So you don't expect the VM to ever call these functions? Why?
Pekka
|