[lkml]   [2008]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [UPDATED v3][PATCH 4/7] regulator: framework core
On Sat, 08 Mar 2008 17:24:46 +0000 Liam Girdwood <> wrote:

> > Should be indented with a tab, not spacespacespacespace
> This patch releases the lock in get_device_regulator(), makes
> get_lowest_stable_voltage() non inline and fixes a minor indentation
> issue.

OK, I'll toss it in there, thanks.

It sounds like significant changes will be happening and that we can expect
to see a new patchset?

I assume you noted my s/get_current/read_current/g fix? It'll be needed for
alpha, frv and mn10300. read_current() is a pretty crappy name but I couldn't
think of anything better. It would look nicer if we also did
s/get_voltage/read_voltage/g - your call.

 \ /
  Last update: 2008-03-08 19:35    [W:0.028 / U:14.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site