lkml.org 
[lkml]   [2008]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument
    On Wed, 27 Feb 2008 19:58:39 -0500
    Andres Salomon <dilinger@queued.net> wrote:

    > On Wed, 27 Feb 2008 16:31:05 -0800
    > Andrew Morton <akpm@linux-foundation.org> wrote:
    >
    > > On Sat, 23 Feb 2008 01:10:45 -0500
    > > Andres Salomon <dilinger@queued.net> wrote:
    > >
    > > > @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options)
    > > > if (!*opt)
    > > > continue;
    > > >
    > > > - mode_option = opt;
    > > > + if (!strncmp(opt, "fbsize:", 7))
    > > > + fbsize = simple_strtoul(opt+7, NULL, 0);
    > > > + else
    > > > + mode_option = opt;
    > > > }
    > >
    > > The above shouldn't be necessary.
    >
    > It looks like that's done in other drivers in case MODULE isn't defined. I'm
    > assuming this is historical at this point, and manual options parsing can
    > be removed from all fb drivers at this point, or is there another reason
    > why manual parsing would be necessary?
    >

    Could I get an answer from the fbdevel folks about this? It looks like
    the fb_get_options stuff is there for backwards compatibility.
    gxfb.fbsize=16777216 (for example) works regardless of whether or not
    CONFIG_MODULES is set.



    >
    > >
    > > And it should have been documented in Documentation/kernel-parameters.txt.
    >
    > Yeah, I wasn't actually sure about that; I did check for other fb drivers
    > documenting stuff in kernel-parameters.txt, and didn't see it. It looks
    > like they instead document stuff in Documentation/fb/. Which is preferred?
    >

    I'd also like an opinion on this.


    \
     
     \ /
      Last update: 2008-03-09 02:19    [W:0.024 / U:29.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site