Messages in this thread Patch in this message | | | Date | Sat, 08 Mar 2008 16:11:05 +0800 (CST) | Subject | [PATCH] Fix check after use in kernel/exit.c | From | WANG Cong <> |
| |
mm_release won't check the mm_struct pointer, so it should be checked before this call.
This patch was first posted here[1], and I don't know why it was not accepted yet.
Thanks to "G. Vaughan" to remind me about this.
1. http://lkml.org/lkml/2007/11/15/520
Cc: Ingo Molnar <mingo@elte.hu> Cc: "G. Vaughan" <gvaughan@jpl.nasa.gov> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
--- kernel/exit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/exit.c b/kernel/exit.c index cd20bf0..0cb9cce 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -582,9 +582,9 @@ static void exit_mm(struct task_struct * tsk) { struct mm_struct *mm = tsk->mm; - mm_release(tsk, mm); if (!mm) return; + mm_release(tsk, mm); /* * Serialize with any possible pending coredump. * We must hold mmap_sem around checking core_waiters -- 1.5.2.4
| |